Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(text): tight option #1110

Merged
merged 13 commits into from Nov 11, 2021
Merged

fix(text): tight option #1110

merged 13 commits into from Nov 11, 2021

Conversation

rachelbt
Copy link
Contributor

  • added a tight option for titles with no margin needed
  • fixed the login example

@github-actions
Copy link

🚀

Latest successful build of the PR deployed here.

🚀

yinonov
yinonov suggested changes Nov 1, 2021
View reviewed changes
Copy link
Contributor

@yinonov yinonov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rachelbt the text snapshot is updated here so once merged, it will remove the buttons' PR difference of that snapshot

components/text/readme.md Outdated Show resolved Hide resolved
components/text/src/vwc-text-base.ts Outdated Show resolved Hide resolved
rachelbt and others added 3 commits November 1, 2021 12:18
@rachelbt rachelbt requested a review from yinonov November 1, 2021 12:56
yinonov
yinonov reviewed Nov 5, 2021
View reviewed changes
components/text/readme.md Outdated Show resolved Hide resolved
@rachelbt
Copy link
Contributor Author

rachelbt commented Nov 7, 2021 •
edited

I don't think fait is right. I think we should either use tight or noSpacing

@rachelbt rachelbt requested a review from yinonov November 7, 2021 12:23
@sonarcloud
Copy link

sonarcloud bot commented Nov 10, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@rachelbt rachelbt merged commit 1dadbc4 into master Nov 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yinonov yinonov yinonov approved these changes

@rinaok rinaok Awaiting requested review from rinaok

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rachelbt @yinonov