Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(usage-examples): add example with top bar fixed #1113

Merged
merged 14 commits into from Nov 2, 2021
Merged

feat(usage-examples): add example with top bar fixed #1113

merged 14 commits into from Nov 2, 2021

Conversation

rinaok
Copy link
Contributor

@rinaok rinaok commented Oct 31, 2021

Description

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@github-actions
Copy link

🚀

Latest successful build of the PR deployed here.

🚀

@rinaok rinaok marked this pull request as ready for review October 31, 2021 15:25
@rinaok rinaok changed the title Viv-763-vwc-top-app-bar-template feat(usage-examples): add example with top bar fixed Oct 31, 2021
@rinaok rinaok requested a review from yinonov November 2, 2021 08:13
@sonarcloud
Copy link

sonarcloud bot commented Nov 2, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@rinaok rinaok merged commit a74c0ee into master Nov 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rachelbt rachelbt rachelbt approved these changes

@yinonov yinonov Awaiting requested review from yinonov

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rinaok @rachelbt