Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(side-drawer): add font-face and refactor side-drawer story #1116

Merged
merged 10 commits into from Nov 4, 2021
Merged

fix(side-drawer): add font-face and refactor side-drawer story #1116

merged 10 commits into from Nov 4, 2021

Conversation

rinaok
Copy link
Contributor

@rinaok rinaok commented Nov 1, 2021

Description

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@github-actions
Copy link

github-actions bot commented Nov 1, 2021

🚀

Latest successful build of the PR deployed here.

🚀

@rinaok rinaok marked this pull request as draft November 1, 2021 15:46
@rinaok rinaok marked this pull request as ready for review November 1, 2021 15:51
@rinaok rinaok changed the title fix(side-drawer): add font-face fix(side-drawer): add font-face and refactor side-drawer story Nov 3, 2021
rachelbt
rachelbt reviewed Nov 4, 2021
View reviewed changes
Copy link
Contributor

@rachelbt rachelbt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there's something wrong in the scroll in the example when the screen is small that leaves a white strip at the top:
image

components/side-drawer/stories/side-drawer-basic.stories.js Outdated Show resolved Hide resolved
components/side-drawer/stories/side-drawer-basic.stories.js Show resolved Hide resolved
components/side-drawer/stories/side-drawer-dismissible-and-modal.stories.js Outdated Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented Nov 4, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@rinaok
Copy link
Contributor Author

rinaok commented Nov 4, 2021 •
edited

there's something wrong in the scroll in the example when the screen is small that leaves a white strip at the top: image

.sb-show-main.sb-main-padded {padding: 0;} fixed it :)

@rinaok rinaok requested a review from rachelbt November 4, 2021 10:35
@rinaok rinaok merged commit 057f054 into master Nov 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rachelbt rachelbt rachelbt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rinaok @rachelbt