Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[accordion] add support for meta data in header #1126

Closed
jshenkman opened this issue Nov 14, 2021 · 3 comments · Fixed by #1225
Closed

[accordion] add support for meta data in header #1126

jshenkman opened this issue Nov 14, 2021 · 3 comments · Fixed by #1225
Assignees
Labels
A11y A11y issues / enhancements Type: Feature

Comments

@jshenkman
Copy link
Contributor

jshenkman commented Nov 14, 2021

Design is here

I used a badge for the meta-data

@yinonov
Copy link
Contributor

yinonov commented Jan 26, 2022

A long awaited request was previously raised to provide support for badge (or any other meta data text content) within the title button area.

going through some leading libraries, there's not much evidence of such implementations. the only few have showed a strict version of meta where elements are defined and handled by the library maintainers.

BBC accordion, for example, feature meta text to reflect items count

image

meaning only text content is allowed as part of the title (label).

notice that an implementations such as the following
image

will cause the accessibility tree to output unclear (but tolerable?) button label - Layout 5
image

as some designs contain other types of elements in the meta space (other than badges, or different types of badges, outlined / filled), it will require a slot to be exposed.
slots are vulnerable, therefore discouraged where "abuse" or wrong content can produce violations.

after considering all meta forms, and accepting the fact that label will concatenate with the meta text (in the accessibility tree), we should recommend string input only in the form of property, where its UI representation will be specified by the component and not by author.

@yinonov
Copy link
Contributor

yinonov commented Jan 26, 2022

relates to #1218

@yinonov yinonov added the A11y A11y issues / enhancements label Jan 26, 2022
@rachelbt rachelbt self-assigned this Jan 31, 2022
@rachelbt
Copy link
Contributor

rachelbt commented Feb 1, 2022

@rachelbt rachelbt linked a pull request Feb 1, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A11y A11y issues / enhancements Type: Feature
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants