Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(side-drawer): add end and start positions #1146

Merged
merged 17 commits into from Dec 14, 2021
Merged

feat(side-drawer): add end and start positions #1146

merged 17 commits into from Dec 14, 2021

Conversation

rinaok
Copy link
Contributor

@rinaok rinaok commented Dec 7, 2021

No description provided.

@rinaok rinaok self-assigned this Dec 7, 2021
@github-actions
Copy link

github-actions bot commented Dec 7, 2021

🚀

Latest successful build of the PR deployed here.

🚀

@rinaok rinaok linked an issue Dec 7, 2021 that may be closed by this pull request
Make it possible for the drawer/side drawer to appear from right side #1137
Closed
@rinaok rinaok marked this pull request as ready for review December 8, 2021 11:18
@rinaok rinaok requested a review from rachelbt December 8, 2021 11:18
@rinaok rinaok requested a review from yinonov December 8, 2021 12:21
yinonov
yinonov suggested changes Dec 8, 2021
View reviewed changes
__snapshots__/Side-drawer.md Outdated Show resolved Hide resolved
__snapshots__/Side-drawer.md Outdated Show resolved Hide resolved
components/side-drawer/src/vwc-side-drawer-base.ts Outdated Show resolved Hide resolved
@yinonov yinonov marked this pull request as draft December 8, 2021 20:37
yinonov
yinonov suggested changes Dec 8, 2021
View reviewed changes
Copy link
Contributor

@yinonov yinonov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check modal and dismissible
image

@rinaok
Copy link
Contributor Author

rinaok commented Dec 12, 2021

check modal and dismissible image

@yinonov
Modal and dismissible side-drawers only work on full pages, could you clarify which example you are looking at?

@yinonov
Copy link
Contributor

yinonov commented Dec 12, 2021 •
edited

check modal and dismissible image

@yinonov

Modal and dismissible side-drawers only work on full pages, could you clarify which example you are looking at?

Align to end should also work on modal / dismissible

Edit: seem like it works now

@rinaok rinaok marked this pull request as ready for review December 13, 2021 09:37
@rinaok rinaok requested a review from yinonov December 13, 2021 15:43
@rinaok rinaok requested a review from yinonov December 14, 2021 15:16
yinonov
yinonov previously approved these changes Dec 14, 2021
View reviewed changes
@sonarcloud
Copy link

sonarcloud bot commented Dec 14, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@rinaok rinaok merged commit 8d712da into master Dec 14, 2021
@yinonov yinonov deleted the viv-1137-side-drawer-right-side branch December 14, 2021 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rachelbt rachelbt rachelbt left review comments

@yinonov yinonov yinonov approved these changes

Assignees

@rinaok rinaok

Labels
None yet
Projects
Vivid Roadmap
Status: Done ✅
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make it possible for the drawer/side drawer to appear from right side
3 participants
@rinaok @yinonov @rachelbt