Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

select dense no-label padding bug #1167

Closed
rachelbt opened this issue Dec 23, 2021 · 0 comments · Fixed by #1168
Closed

select dense no-label padding bug #1167

rachelbt opened this issue Dec 23, 2021 · 0 comments · Fixed by #1168
Assignees
@rachelbt

Comments

@rachelbt
Copy link
Contributor

rachelbt commented Dec 23, 2021 •
edited

When there's no label to the select there was an unneeded padding top.
Was fixed but the fix caused a design break due to extracting the select background color.
padding need to be changed to margin
@rachelbt rachelbt self-assigned this Dec 23, 2021
@rachelbt rachelbt changed the title select dense no-label padding select dense no-label padding bug Dec 23, 2021
@rachelbt rachelbt linked a pull request Dec 23, 2021 that will close this issue
fix(select): remove extended bg due to padding #1168
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rachelbt rachelbt

Labels
None yet
Projects
Vivid Roadmap
Status: Done ✅
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(select): remove extended bg due to padding Vonage/vivid
1 participant
@rachelbt