New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(elevation): remove containment #1188
Conversation
🚀 Latest successful build of the PR deployed here. 🚀 |
I think its better that there will be a case of missing border-radius rather then hidden content |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe we can remove border-radius on elevation altogether?
It does :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can just remove the border radius from elevation as drop-shadow will take into consideration the shape of content.
So we leave shaping responsibility to
Kudos, SonarCloud Quality Gate passed! |
contain: content
causes nested components to be un-shown because popup position is absolute.see codepen: https://codepen.io/rachelbt/pen/jOGKqox
added ::slotted(*) for border-radius inherit (inherit doesn't)