Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(snackbar): support heading in non legacy mode #1192

Merged
merged 6 commits into from Feb 28, 2022

Conversation

YonatanKra
Copy link
Contributor

@YonatanKra YonatanKra commented Jan 12, 2022

closes #1191

@github-actions
Copy link

🚀

Latest successful build of the PR deployed here.

🚀

@yinonov
Copy link
Contributor

yinonov commented Jan 12, 2022

snackbar heading only apply to legacy for Volta parity. the default snackbar style doesn't feature heading

@yinonov yinonov closed this Jan 12, 2022
@yinonov yinonov reopened this Jan 12, 2022
@github-actions
Copy link

🚀

Latest successful build of the PR deployed here.

🚀

@yinonov yinonov changed the title fix(snackbar): now showing the header in non legacy mode fix(snackbar): support heading in non legacy mode Jan 23, 2022
@yinonov yinonov added Type: Feature Type: Component 🛠 Assigned to PRs delivering brand-new components to the Vivid catalog labels Jan 26, 2022
yinonov
yinonov previously approved these changes Jan 30, 2022
@sonarcloud
Copy link

sonarcloud bot commented Feb 28, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@YonatanKra YonatanKra merged commit 3d88e47 into master Feb 28, 2022
@YonatanKra YonatanKra deleted the ISSUE-1191/fix/snackbar-header-not-showing branch February 28, 2022 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Component 🛠 Assigned to PRs delivering brand-new components to the Vivid catalog Type: Feature
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[snackbar]: header doesn't show in non legacy mode
3 participants