New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(snackbar): support heading in non legacy mode #1192
Merged
YonatanKra
merged 6 commits into
master
from
ISSUE-1191/fix/snackbar-header-not-showing
Feb 28, 2022
Merged
fix(snackbar): support heading in non legacy mode #1192
YonatanKra
merged 6 commits into
master
from
ISSUE-1191/fix/snackbar-header-not-showing
Feb 28, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🚀 Latest successful build of the PR deployed here. 🚀 |
snackbar heading only apply to legacy for Volta parity. the default snackbar style doesn't feature heading |
🚀 Latest successful build of the PR deployed here. 🚀 |
yinonov
changed the title
fix(snackbar): now showing the header in non legacy mode
fix(snackbar): support heading in non legacy mode
Jan 23, 2022
yinonov
added
Type: Feature
Type: Component 🛠
Assigned to PRs delivering brand-new components to the Vivid catalog
labels
Jan 26, 2022
yinonov
previously approved these changes
Jan 30, 2022
…191/fix/snackbar-header-not-showing � Conflicts: � ui-tests/index.ts
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
rachelbt
approved these changes
Feb 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Type: Component 🛠
Assigned to PRs delivering brand-new components to the Vivid catalog
Type: Feature
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1191