New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Dialog] add support for position-top #1215

Closed

jshenkman opened this issue Jan 26, 2022 · 1 comment · Fixed by #1226

Assignees

Labels

Contributor

jshenkman commented Jan 26, 2022 •

edited

In modal component, we would want to allow the following positioning -

position-center - currently the only option available
position-top - new request.

The request came from VR - VBC admin product for modal with changing sizes, so the position will stay fixed as the modal changes.

jshenkman assigned yinonov

jshenkman added the Type: Feature label

yinonov changed the title ~~[Modal] add support for position-top~~ [Dialog] add support for position-top

rachelbt self-assigned this

rachelbt linked a pull request

that will close this issue

feat(dialog): custom top position #1226

Merged

Contributor

rachelbt commented Feb 2, 2022

@jshenkman
Story-book:
https://tmp.dev.vivid.vonage.com/1226/index.html?path=/story/components-dialog--top-position&args=topPosition:true

rachelbt closed this as completed in #1226

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment