Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(textfield): support character count #1245

Merged
merged 6 commits into from Mar 10, 2022
Merged

feat(textfield): support character count #1245

merged 6 commits into from Mar 10, 2022

Conversation

yinonov
Copy link
Contributor

@yinonov yinonov commented Feb 27, 2022

Description

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@github-actions
Copy link

🚀

Latest successful build of the PR deployed here.

🚀

@yinonov yinonov linked an issue Feb 27, 2022 that may be closed by this pull request
position: absolute;
top: -25px;
right: 0;
color: var(#{scheme-variables.$vvd-color-neutral-70}) !important;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you could use the same hierarchy as in material and you will not need the important:
.mdc-text-field:not(.mdc-text-field--disabled) {...}

@sonarcloud
Copy link

sonarcloud bot commented Mar 10, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@yinonov yinonov merged commit 9666bde into master Mar 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[Text-field] support character count
3 participants