feat(breadcrumb): add the breadcrumb component #1260
Conversation
|
🚀 Latest successful build of the PR deployed here. 🚀 |
| }, | ||
| "dependencies": { | ||
| "@vonage/vvd-foundation": "^2.26.0", | ||
| "lit-element": "^2.4.0", |
There was a problem hiding this comment.
Yes it should be imported in all vivid < 3 components
There was a problem hiding this comment.
Actually - it doesn't use any of these...
I've removed v-2 deps. Left only umbrella for build time dep.
Co-authored-by: yinon <yinon@hotmail.com>
# Conflicts: # components/icon/package.json # components/icon/src/vwc-icon.ts
| const style = document.createElement('style'); | ||
| style.innerHTML = ` | ||
| vwc-breadcrumb { | ||
| --icon-size: 14px; | ||
| } | ||
| `; | ||
| document.head.appendChild(style); |
There was a problem hiding this comment.
We need to set the icon's size inside the element.
Since we have no access to the scss file and actually have no scss file, this is the way I thought of doing it.
Got a suggestion?
Co-authored-by: yinon <yinon@hotmail.com>
YonatanKra
force-pushed
the
breadcrumb-component
branch
2 times, most recently
from
b0898d1
to
71381db
Compare
YonatanKra
force-pushed
the
breadcrumb-component
branch
from
513ce48
to
cb6df73
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
| }, | ||
| "scripts": { | ||
| "build:typescript": "tsc -b", | ||
| "build:styles": "umbrella-style-modules --cssLib '@microsoft/fast-element'", |
| </vwc-breadcrumb>`; | ||
|
|
||
| export const Basic = Template.bind({}); | ||
| Basic.args = { label: 'Basic', disabled: 'false' }; |
There was a problem hiding this comment.
there's no use of either of them in the code - I think you better remove them, less confusion to our users :)
Adds the
breadcrumbandbreadcrumb-itemcomponents.Note that this is "quick and dirty" as
vivid-2is deprecated. No unit tests involved - mainly copy-paste of code fromvivid-3