Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(fab): elevated undefined connotation #1261

Merged
merged 7 commits into from Mar 23, 2022
Merged

feat(fab): elevated undefined connotation #1261

merged 7 commits into from Mar 23, 2022

Conversation

yinonov
Copy link
Contributor

@yinonov yinonov commented Mar 21, 2022

Description

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@github-actions
Copy link

🚀

Latest successful build of the PR deployed here.

🚀

@yinonov yinonov changed the title feat(fab): undefined connotation filled as canvas feat(fab): elevated undefined connotation Mar 22, 2022
@rachelbt
Copy link
Contributor

looks Good :)
2 little issues:

  1. the icon has spacing bug when its at the end of the icon:
    image
  2. theres no style for disabled (there was non to begin with - maybe this need to be set as different issue)

@yinonov yinonov requested a review from rachelbt March 23, 2022 11:06
@yinonov yinonov merged commit 7d155c1 into master Mar 23, 2022
@yinonov yinonov deleted the fab-style branch March 23, 2022 12:06
@sonarcloud
Copy link

sonarcloud bot commented Mar 23, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rachelbt rachelbt Awaiting requested review from rachelbt

Assignees
No one assigned
Labels
Type: Design 🎨
Projects
Vivid Roadmap
Status: Done ✅
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@yinonov @rachelbt