New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(tags): support removable #1266
Conversation
🚀 Latest successful build of the PR deployed here. 🚀 |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
will handle tag open issues in a different scope |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there's no option for both selected & removable. Is it intentionally?
There's no removable option in the UI test
Co-authored-by: rachelbt <rachelbt@users.noreply.github.com>
actually that's a good question. I don't think they should co-exist but it's not specified. let's try to monitor public feedback and "field" testing. semantics & a11y concerns should be researched here |
I think we need to add wither just cursor pointer to the button or both that & ripple to indicate that the X is a button and not decorative |
It is addressed in different issues |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
issues to resolve: