Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(calendar): calendar focus interactions damaged #1271

Merged
merged 7 commits into from Apr 13, 2022
Merged

fix(calendar): calendar focus interactions damaged #1271

merged 7 commits into from Apr 13, 2022

Conversation

yinonov
Copy link
Contributor

@yinonov yinonov commented Apr 4, 2022

Description

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@github-actions
Copy link

github-actions bot commented Apr 4, 2022

🚀

Latest successful build of the PR deployed here.

🚀

@rachelbt rachelbt linked an issue Apr 6, 2022 that may be closed by this pull request
Calendar header has a white background when it shouldn't #1277
Closed
@yinonov yinonov marked this pull request as ready for review April 12, 2022 08:37
@yinonov yinonov requested a review from rachelbt April 12, 2022 11:06
@rachelbt
Copy link
Contributor

you also need to generate new PNG ui-test

rachelbt
rachelbt previously approved these changes Apr 12, 2022
View reviewed changes
Copy link
Contributor

@rachelbt rachelbt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yinonov yinonov requested a review from rachelbt April 13, 2022 06:50
@sonarcloud
Copy link

sonarcloud bot commented Apr 13, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@yinonov yinonov merged commit c84bdac into master Apr 13, 2022
@yinonov yinonov deleted the calendar-bug branch April 13, 2022 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rachelbt rachelbt rachelbt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Vivid Roadmap
Status: Done ✅
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Calendar header has a white background when it shouldn't
3 participants
@yinonov @rachelbt @YonatanKra