Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(menu): background and shadow colors #1280

Merged
merged 13 commits into from May 4, 2022
Merged

fix(menu): background and shadow colors #1280

merged 13 commits into from May 4, 2022

Conversation

rachelbt
Copy link
Contributor

No description provided.

@rachelbt rachelbt linked an issue Apr 10, 2022 that may be closed by this pull request
[menu]: surface background in dark them #1279
Closed
@rachelbt rachelbt requested a review from yinonov April 10, 2022 13:22
@github-actions
Copy link

🚀

Latest successful build of the PR deployed here.

🚀

@rachelbt
Copy link
Contributor Author

@jshenkman
menu: https://tmp.dev.vivid.vonage.com/1280/index.html?path=/story/components-menu--with-vwc-list-item
dropdown: https://tmp.dev.vivid.vonage.com/1280/index.html?path=/story/alpha-components-dropdown--basic&args=corner:BOTTOM_START

@jshenkman
Copy link
Contributor

@jshenkman menu: https://tmp.dev.vivid.vonage.com/1280/index.html?path=/story/components-menu--with-vwc-list-item dropdown: https://tmp.dev.vivid.vonage.com/1280/index.html?path=/story/alpha-components-dropdown--basic&args=corner:BOTTOM_START

LGTM!! 🤩😍

yinonov
yinonov suggested changes Apr 11, 2022
View reviewed changes
components/surface/src/vwc-surface.scss Outdated Show resolved Hide resolved
components/surface/src/vwc-surface.scss Outdated Show resolved Hide resolved
@rachelbt rachelbt requested a review from yinonov April 11, 2022 06:46
yinonov
yinonov suggested changes Apr 26, 2022
View reviewed changes
Copy link
Contributor

@yinonov yinonov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should select be scoped to this fix

image

@rachelbt
Copy link
Contributor Author

should select be scoped to this fix

image

basically yes - the problem is that in the select we are using the mwc-menu-surface and not the vivid one.
If this need to be fixed - its a different task for my opinion

yinonov
yinonov suggested changes May 4, 2022
View reviewed changes
Copy link
Contributor

@yinonov yinonov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

checking

@sonarcloud
Copy link

sonarcloud bot commented May 4, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@rachelbt rachelbt merged commit 40e02cd into master May 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yinonov yinonov yinonov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Vivid Roadmap
Status: Done ✅
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[menu]: surface background in dark them
3 participants
@rachelbt @jshenkman @yinonov