fix(button-toggle-group): fix race condition between values property and slotted buttons #1324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚀 Latest successful build of the PR deployed here. 🚀 |
YonatanKra
changed the title
|
🚀 Latest successful build of the PR deployed here. 🚀 |
k-paxian
reviewed
Jun 24, 2022
k-paxian
requested changes
Jun 28, 2022
YonatanKra
force-pushed
the
1321-vwc-button-toggle-group-race-condition-between-values-property-and-child-buttons-in-the-main-slot
branch
from
6805f87
to
21a7f48
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
k-paxian
approved these changes
Jun 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@k-paxian - would appreciate if you could review this one and make sure it answers the use case (note the test I've added)