feat(vwc-calendar): calendar 1st draft #564
Conversation
|
🚀 Latest successful build of the PR deployed here. 🚀 |
|
Minimum allowed coverage is Generated by 🐒 cobertura-action against 16393b7 |
| <ol class="calendar"> | ||
| ${this.renderTimeCells()} | ||
| <!-- TODO: should be presented as a custom element. then could look for siblings and indent by js --> | ||
| <section |
There was a problem hiding this comment.
can <section> be a child of <ol>?
There was a problem hiding this comment.
that's correct, but later we'd might use a custom element for that section, that's a pickle that is also issued in mwc-list. any suggestions?
There was a problem hiding this comment.
ones that will extend li?
There was a problem hiding this comment.
No, no extending native elements, not supported on Safari, etc.
But could an li element hold this content? Yes it can, so just anything we'd like to push there may be put into the li, WDYT?
There was a problem hiding this comment.
will <vwc-event> with <li> in its shadow do?
There was a problem hiding this comment.
Honestly, anything will do - the HTML is not restrictive, but if we want to stick to it, as per @tveinfeld comment - ol direct children may only be li (or template or script, i think too, but not relevant).
So if any - i'd say li element and within it vwc-event and not otherwise.
...and of course, given that it's our component and given that you actually not really using a list features here and even semantically it is not strictly it - just drop the li and use anything else - IMHO, that would be the simplest
There was a problem hiding this comment.
i'll follow the material pattern which is an li within a custom element wrapper. in the next calendar PR. it is a 1st draft
|
Kudos, SonarCloud Quality Gate passed!
|
Alpha version of calendar. should be exposed to promote and get feedback on how to move forward with its API (currently no API featured)
no existing tests