feat(vwc-helper-message): commonalize text helper component #575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gullerya
requested review from
YonatanKra and
yinonov
and removed request for
YonatanKra
|
🚀 Latest successful build of the PR deployed here. 🚀 |
|
Minimum allowed coverage is Generated by 🐒 cobertura-action against 64374cf |
Co-authored-by: Joel Graham <j.r.g@hotmail.com>
gullerya
commented
Jan 14, 2021
…ub.com/Vonage/vivid into tech-commonalize-text-helper-component
|
I'm skipping review of yaml files |
|
Kudos, SonarCloud Quality Gate passed!
|
yinonov
reviewed
Jan 15, 2021
| @@ -36,7 +36,7 @@ jobs: | |||
| path: | | |||
| ${{ steps.yarn-cache-dir-path.outputs.dir }} | |||
| **/node_modules | |||
| key: vivid-cache-yarn-${{ hashFiles('**/yarn.lock') }} | |||
| key: vivid-cache-yarn-${{ hashFiles('**/package.json') }} | |||
There was a problem hiding this comment.
is this likely to change in the future? can it be an environment variable?
There was a problem hiding this comment.
don't think so - this is just about to clean our cache each time anything related to node_modules changes
| protected render(): TemplateResult { | ||
| return html` | ||
| <vwc-icon class="helper-icon" type="info-negative" size="small"></vwc-icon> | ||
| <span class="helper-text"><slot></slot></span> |
There was a problem hiding this comment.
ideas for a11y, aria, wai-aria?
There was a problem hiding this comment.
NP, I'll think about and we'll do some improvements round (opening a ticket for that)
yinonov
approved these changes
Jan 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
textarea, textfield, select and file-picker - are all using the same logic to show a helper message which can turn to be an error message with error icon on demand.
This component make them all using the same thing, reduces amount of duplicate code, dependencies on some internal stuff of MWC and also available as a stand-alone functionality for the consumer applications.