Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(datepicker): lit-flatpicker proof of concept #600

Merged
merged 43 commits into from
Feb 10, 2021
Merged

Conversation

JoelGraham93
Copy link
Contributor

Implementation of lit-flatpickr - built with lit-element to wrap flatpickr

Investigating potential bug where date + time mode does not render time container

@JoelGraham93 JoelGraham93 added the Work in Progress You're welcome to have a look around and drop your early comments label Jan 21, 2021
@github-actions
Copy link

🚀

Latest successful build of the PR deployed here.

🚀

@JoelGraham93
Copy link
Contributor Author

Opened PR Matsuuu/lit-flatpickr#4 to fix hidden time picker bug Matsuuu/lit-flatpickr#2

@JoelGraham93
Copy link
Contributor Author

Opened PR Matsuuu/lit-flatpickr#4 to fix hidden time picker bug Matsuuu/lit-flatpickr#2

PR merged and package updated in 6e60896

@yinonov
Copy link
Contributor

yinonov commented Feb 6, 2021

@JoelGraham93 👏 for contributing back to the used library!
The PR is "still a work in progress" convert to "ready for review" and merge at will

yinonov
yinonov previously approved these changes Feb 6, 2021
@yinonov yinonov marked this pull request as ready for review February 7, 2021 15:26
yinonov
yinonov previously approved these changes Feb 9, 2021
@sonarcloud
Copy link

sonarcloud bot commented Feb 10, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
2.2% 2.2% Duplication

@yinonov yinonov merged commit 95a8ecc into master Feb 10, 2021
@JoelGraham93 JoelGraham93 deleted the lit-flatpickr-demo branch February 10, 2021 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Work in Progress You're welcome to have a look around and drop your early comments
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants