Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(storybook): attempt to fix the fonts preload #624

Merged
merged 6 commits into from
Feb 1, 2021

Conversation

gullerya
Copy link
Contributor

@gullerya gullerya commented Feb 1, 2021

No description provided.

@gullerya gullerya marked this pull request as draft February 1, 2021 11:46
@github-actions
Copy link

github-actions bot commented Feb 1, 2021

🚀

Latest successful build of the PR deployed here.

🚀

@gullerya
Copy link
Contributor Author

gullerya commented Feb 1, 2021

Looking on some commit in the MWC my though was that remove 'crossorigin' would solve it.
But that's apparently not correct nor at of MDN documentation neither due to the following errors, showing in the Chrome's console removing 'crossorigin':

The resource https://fonts.resources.vonage.com/fonts/v1/Spezia_Web_Complete_Upright.woff2 was preloaded using link preload but not used within a few seconds from the window's load event. Please make sure it has an appropriate as value and it is preloaded intentionally.

So first - back to the crossorigin, then we'll review if we'd like to suggest this preload at all.

@sonarcloud
Copy link

sonarcloud bot commented Feb 1, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@gullerya gullerya requested a review from yinonov February 1, 2021 15:34
@gullerya gullerya marked this pull request as ready for review February 1, 2021 15:35
@gullerya gullerya merged commit 7cdf9ff into master Feb 1, 2021
@gullerya gullerya deleted the storybook-fonts-issue branch February 1, 2021 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants