fix(select): issue #627 select dense label #628
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #627
This PR takes a deliberate change in the dense of select behavior - to cope with some ambiguity that was seen in the admin app of the UP: when label attribute is not present (even if the label IS set), the dense appears corrupted.
This PR reflects this take:
Additionally this PR fixes few a11y issues left unaddressed by MWC.
Additionally this PR adds few tests for fortification.