fix(button/icon): fixing the icon disposition in button #653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚀 Latest successful build of the PR deployed here. 🚀 |
yinonov
previously approved these changes
Feb 10, 2021
|
Kudos, SonarCloud Quality Gate passed!
|
JoelGraham93
approved these changes
Feb 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the icon disposition in the button.
Pay attention, that in the dev.vivid.vonage.com the icon is few pixels above.
The solution is to change the
inline-flexof the icon to be justflex- please consider if that may have any side effects that i've missed (don't know why not used it in the first place).Also, pay attention that there is no need in some CSS in button due to this change (and that CSS hasn't really helped anyway).