Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(vwc-icon): icon flow defaults to inline-block #663

Merged
merged 10 commits into from
Feb 16, 2021
Merged

fix(vwc-icon): icon flow defaults to inline-block #663

merged 10 commits into from
Feb 16, 2021

Conversation

yinonov
Copy link
Contributor

@yinonov yinonov commented Feb 14, 2021

Description

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@github-actions
Copy link

🚀

Latest successful build of the PR deployed here.

🚀

@yinonov yinonov marked this pull request as draft February 14, 2021 21:18
@yinonov
Copy link
Contributor Author

yinonov commented Feb 16, 2021

list item meta still seem a little off
image

@JoelGraham93
Copy link
Contributor

list item meta still seem a little off
image

resolved in 13a6bca

@sonarcloud
Copy link

sonarcloud bot commented Feb 16, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@gullerya gullerya marked this pull request as ready for review February 16, 2021 14:52
@gullerya gullerya merged commit 303dd74 into master Feb 16, 2021
@gullerya gullerya deleted the VIV-405-icon-inlined branch February 17, 2021 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gullerya gullerya gullerya approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@yinonov @JoelGraham93 @gullerya