Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(vwc-media-controller): stylelint formatting duplication of selector #669

Merged
merged 5 commits into from
Feb 21, 2021
Merged

fix(vwc-media-controller): stylelint formatting duplication of selector #669

merged 5 commits into from
Feb 21, 2021

Conversation

yinonov
Copy link
Contributor

@yinonov yinonov commented Feb 18, 2021

Description

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@github-actions
Copy link

🚀

Latest successful build of the PR deployed here.

🚀

@tveinfeld
Copy link
Contributor

Fixes https://jira.vonage.com/browse/VIV-411

tveinfeld
tveinfeld suggested changes Feb 20, 2021
View reviewed changes
Copy link
Contributor

@tveinfeld tveinfeld left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change doesn't fix VIV-411. Please review in storybook.

components/media-controller/src/vwc-media-controller.scss Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented Feb 20, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@yinonov yinonov merged commit 343d62b into master Feb 21, 2021
@gullerya gullerya deleted the viv-411-stylelint-side-effects branch February 24, 2021 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tveinfeld tveinfeld tveinfeld approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@yinonov @tveinfeld