fix: make datepicker compatible with dialog #680
Conversation
|
🚀 Latest successful build of the PR deployed here. 🚀 |
No only outside of |
components/datepicker/.depcheckrc
Outdated
| "lit-flatpickr", | ||
| "@vonage/vvd-core", | ||
| "@vonage/vwc-datepicker", | ||
| "@vonage/vwc-textfield", | ||
| "@vonage/vwc-dialog", | ||
| "@open-wc/*" | ||
| ] |
There was a problem hiding this comment.
why are we ignoring dependencies anyway?
| @@ -0,0 +1,798 @@ | |||
| // copy paste from flatpicker/dist/flatpickr.css | |||
There was a problem hiding this comment.
is this the flatpicker library original css? if so, can we just import it to our style (vwc-datepicker.scss)?
https://sass-lang.com/documentation/at-rules/import#importing-css
There was a problem hiding this comment.
Yes it's the original css.
css imports don't appear to be working in our css module setup.
I read on the polymer slack channel that the mwc team had a build process which converts their .css files to .css.ts and wraps it in a css template literal export const style = css '...'
There was a problem hiding this comment.
that's exactly what we're doing
I changed the code to reflect what I suggested so that it will proxy the original css code
hope that's ok
There was a problem hiding this comment.
Oh yea nice that works. I tried @import initially which wasn't working with the .css file
|
Kudos, SonarCloud Quality Gate passed!
|
Requirement for Virtual Receptionist app to use datepicker within dialog. figma
mwc-dialog adds the inert attribute to all elements outside of the modal scope. This prevents interaction.