Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(general): removed redundant lerna.json parameter #696

Merged
merged 4 commits into from
Mar 12, 2021

Conversation

tveinfeld
Copy link
Contributor

see documentation at Lerna's website

@github-actions
Copy link

github-actions bot commented Mar 9, 2021

🚀

Latest successful build of the PR deployed here.

🚀

@yinonov
Copy link
Contributor

yinonov commented Mar 9, 2021

see documentation at Lerna's website

see the whole documentation? please narrow down the search, explain or link

@tveinfeld
Copy link
Contributor Author

see documentation at Lerna's website

see the whole documentation? please narrow down the search, explain or link

The PR is pretty self-explanatory: we don't need to state a list of "packages" if we're overriding it by declaring

{ "useWorkspaces": true }

@yinonov yinonov self-requested a review March 10, 2021 14:23
@tveinfeld
Copy link
Contributor Author

see documentation at Lerna's website

see the whole documentation? please narrow down the search, explain or link

The PR is pretty self-explanatory: we don't need to state a list of "packages" if we're overriding it by declaring

{ "useWorkspaces": true }

If --use-workspaces is true then packages will be overridden by the value from package.json/workspaces

@sonarcloud
Copy link

sonarcloud bot commented Mar 11, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@gullerya gullerya merged commit d0ed5f0 into master Mar 12, 2021
@gullerya gullerya deleted the no-jira-remove-conflicting-lerna-json-params branch March 12, 2021 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants