feat(data-grid): allow data-grid to set height according to container #983
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
🚀 Latest successful build of the PR deployed here. 🚀 |
Obsolete as we have a visual test
k-paxian
added a commit
that referenced
this pull request
Jul 23, 2021
…ynamically guided by content #983
yinonov
suggested changes
Jul 25, 2021
Co-authored-by: yinon <yinon@hotmail.com>
…arent Co-authored-by: yinon <yinon@hotmail.com>
yinonov
suggested changes
Jul 25, 2021
Co-authored-by: yinon <yinon@hotmail.com>
yinonov
previously approved these changes
Jul 25, 2021
yinonov
reviewed
Jul 25, 2021
yinonov
reviewed
Jul 25, 2021
yinonov
previously approved these changes
Jul 25, 2021
yinonov
reviewed
Jul 25, 2021
| min-width: 200px; | ||
| height: 320px; | ||
| min-height: 150px; | ||
| display: block; |
There was a problem hiding this comment.
Suggested change
| display: block; |
yinonov
reviewed
Jul 25, 2021
yinonov
reviewed
Jul 25, 2021
|
Kudos, SonarCloud Quality Gate passed!
|
YonatanKra
changed the title
yinonov
approved these changes
Jul 25, 2021
yinonov
approved these changes
Jul 25, 2021
yinonov
added a commit
that referenced
this pull request
Jul 28, 2021
#985) * feat(data-grid): expose `heightByRows` field to control grid height dynamically guided by content #983 * calm lint * height-by-rows attribute convention * refine changes * add space in story * correct description * correct doc Co-authored-by: tveinfeld <67224311+tveinfeld@users.noreply.github.com> Co-authored-by: Yonatan Kra <yonatan.kra@vonage.com> Co-authored-by: yinonov <yinon@hotmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #966
I've removed the unit tests for layout as I've added a visual test.