Qunit 1.14 #62
Merged
Qunit 1.14 #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds two new development dependencies.
First, I wanted to run the qunit tests offline.
Second, as of qunit version 1.13 triggerEvent was removed (see qunitjs/qunit@7789d6a).
Therefore I had to search for a replacement. I found happen.js to fulfil this task. I tried several other microframeworks for this task and found happen to work best.
I run my tests with karma and that works best with the current qunit version 1.14. The next version will resolve following issue: qunitjs/qunit#350
Therefore the tests should be prepared to work with the latest qunit version.