Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Passing names as a filter argument does not work for storage location filter #141

Closed
syed1992 opened this issue Jan 2, 2020 · 1 comment

Comments

@syed1992
Copy link
Contributor

syed1992 commented Jan 2, 2020

image

@kujon
Copy link
Contributor

kujon commented Jan 2, 2020

@syed1992 we have removed this functionality here #134. Long story short, when searching by name, the search requests resolves to IDs in the background. We do a fuzzy search behind the scenes, so e.g. searching for 'India', would include 'Indiana' as well, and the user would have no visibility into why they're getting incorrect results. The alternative would be to do the exact matching, but that would default the point of having user-friendly search, if you have to type e.g. 'Service Terminal Rotterdam (STR)' exactly.

We'll most likely re-introduce this feature as an additional fuzzy_search method to make this behaviour explicit. We'd also return the resolved geographies/products/etc. in the response to tell you exactly what has been matched.

@kujon kujon closed this as completed Jan 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants