Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change default column 'events.cargo_port_load_event.0.start_timestamp' to 'events.cargo_port_load_event.0.end_timestamp' #56

Closed
syed1992 opened this issue Nov 20, 2019 · 2 comments
Closed

change default column 'events.cargo_port_load_event.0.start_timestamp' to 'events.cargo_port_load_event.0.end_timestamp' #56

syed1992 opened this issue Nov 20, 2019 · 2 comments
Labels
invalid This doesn't seem right
Milestone
Beta Release

Comments

@syed1992
Copy link
Contributor

This is to align dates with our convention of departures and arrivals i.e. loading_end and unloading_start
@syed1992 syed1992 added the invalid This doesn't seem right label Nov 20, 2019
@syed1992 syed1992 added this to the Beta Release milestone Nov 20, 2019
@KitBurgess
Copy link
Contributor

Should the events.cargo_port_unload_event.0.start_timestamp also be changed to events.cargo_port_unload_event.0.end_timestamp?

@syed1992
Copy link
Contributor Author

I think events.cargo_port_unload_event.0.start_timestamp should stay the same because we count our arrivals as unloading_start

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
invalid This doesn't seem right
Projects
None yet
Milestone
Beta Release
Development

No branches or pull requests
2 participants
@KitBurgess @syed1992