Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check --doctor on Windows #38

Closed
VorpalBlade opened this issue Oct 1, 2023 · 3 comments
Closed

Check --doctor on Windows #38

VorpalBlade opened this issue Oct 1, 2023 · 3 comments
Assignees

Comments

@VorpalBlade
Copy link
Owner

The PATH logic needs to be verified on Windows. What about the .exe file extension specifically?

@VorpalBlade
Copy link
Owner Author

Probably fixed by f7844cc

@VorpalBlade
Copy link
Owner Author

@lukaszkadlubowski I have just released 2.1.5 that includes the likely fix for this.

I would appreciate if you could test that

  1. The self updater -u works on Windows (if it doesn't that is good to know, but I wouldn't be able to do much except report it onwards to the crate [what libraries are called in the Rust world] that implements this)
  2. Check if --doctor works as expected with this change.

@lukaszkadlubowski
Copy link
Contributor

lukaszkadlubowski commented Oct 11, 2023

I confirm that it works like a charm, here it is the first part of the --doctor output:

PS C:\Users\lk\.local\share\chezmoi> chezmoi_modify_manager --doctor 
RESULT    CHECK                MESSAGE
Info      version              2.1.5
Info      rustc-version        1.72.1
Info      host                 os=windows, arch=x86_64, info=Windows 10.0.19045 (Windows 10 Pro) [64-bit]
Info      has-chezmoi          Chezmoi found. Version: chezmoi version v2.40.0, commit 6a8ca1634654734bb33a036ffb9c21e6b9f4d28d, built at 2023-09-19T09:56:08Z, built by goreleaser
Ok        in-path              chezmoi_modify_manager is in PATH at C:\Users\lk\AppData\Local\chezmoi_modify_manager\chezmoi_modify_manager.exe
Info      has-ignore           Ignore of **/*.src.ini found

Output of chezmoi doctor:
RESULT    CHECK                       MESSAGE
ok        version                     v2.40.0, commit 6a8ca1634654734bb33a036ffb9c21e6b9f4d28d, built at 2023-09-19T09:56:08Z, built by goreleaser
warning   latest-version              v2.40.2
ok        os-arch                     windows/amd64
ok        systeminfo                  Microsoft Windows 10 Pro (10.0.19045 N/A Build 19045)
ok        go-version                  go1.21.1 (gc)
ok        executable                  ~/AppData/Local/Microsoft/WinGet/Packages/twpayne.chezmoi_Microsoft.Winget.Source_8wekyb3d8bbwe/chezmoi.exe 
ok        upgrade-method              replace-executable
etc. ...

Thank you very much for fixing this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants