Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation of pyvw.py #2267

Closed
Smit-create opened this issue Feb 14, 2020 · 7 comments · Fixed by #2336
Closed

Documentation of pyvw.py #2267

Smit-create opened this issue Feb 14, 2020 · 7 comments · Fixed by #2336
Labels
Documentation Issue in samples or documentation

Comments

@Smit-create
Copy link
Contributor

Describe the bug

The documentation of pyvw.py can be corrected i.e to add essential details like Parameters, Return type, Examples etc. The documentation of sklearn_vw.py provides with this essential details and becomes easy to use at the user end. We can also follow the specific patter of documenation in all .py files as in https://numpydoc.readthedocs.io/en/latest/format.html#sections. Is it a good idea?

@jackgerrits
Copy link
Member

100% agree, the documentation can be improved. I do like the suggestion of following the sections that numpy uses, that seems quite complete. Let's see if any others have opinions here.

By the way, docs are hosted here: https://vowpalwabbit.org/docs/vowpal_wabbit/python/html/
They are currently updated manually which is why they are out of date. I've started work on automatic updating, I have CI that generates the docs so I just need to implement the updating.

@Smit-create
Copy link
Contributor Author

Thanks @jackgerrits . Okay lets wait, once everyone agrees, I will open a PR of the same

@Smit-create
Copy link
Contributor Author

By the way, docs are hosted here: https://vowpalwabbit.org/docs/vowpal_wabbit/python/html/

Yes, seems that pyvw.py documentation needs an attention.

@jackgerrits jackgerrits added the Documentation Issue in samples or documentation label Feb 14, 2020
@ARDivekar
Copy link

ARDivekar commented Mar 10, 2020

Related: the documentation pages for https://vowpal-wabbit.readthedocs.io/en/latest/vowpalwabbit.pyvw.html and https://vowpal-wabbit.readthedocs.io/en/latest/vowpalwabbit.sklearn.html seem to be empty?? That looks like a miss.

@thealphadollar
Copy link
Contributor

@jackgerrits Is this issue open for taking up?

@Smit-create
Copy link
Contributor Author

@thealphadollar I am working on it.

@thealphadollar
Copy link
Contributor

Great 😀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Issue in samples or documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants