This repository has been archived by the owner on Nov 18, 2022. It is now read-only.
Editor now shows in-game names #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
November 15, 2021 00:03
Editor displays in-game names for skins, pets, and nameplates. Some tuple indexes were changed to dictionaries to make it easier to switch between the name and the actual ID.
|
Looks good to me, just a note that usually PRs are for one feature/topic exclusively |
|
Also side note 2, I'm pretty sure there's a way to do two-way dicts. That would be useful here I think |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Editor displays in-game names for skins, pets, and nameplates. Some tuple indexes were changed to dictionaries to make it easier to switch between the name and the actual ID in the program.
I didn't change hats or visors yet because there are a lot of them.