Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: Replace ratio_time_limit by seeding_time_limit #1611

Merged
merged 4 commits into from Mar 26, 2024

Conversation

Larsluph
Copy link
Collaborator

@Larsluph Larsluph commented Mar 25, 2024

⚠️ This may cause undefined keys in the properties configuration. Reset your settings to have the latest schema.

@Larsluph Larsluph self-assigned this Mar 25, 2024
@Larsluph Larsluph requested a review from WDaan as a code owner March 25, 2024 13:06
@Larsluph Larsluph marked this pull request as draft March 25, 2024 13:25
@Larsluph Larsluph changed the title perf: Remove empty ratio_time_limit property perf: Replace ratio_time_limit by seeding_time_limit Mar 25, 2024
@Larsluph Larsluph marked this pull request as ready for review March 25, 2024 13:45
@WDaan
Copy link
Collaborator

WDaan commented Mar 25, 2024

Why this change? 🤔

@Larsluph
Copy link
Collaborator Author

Why this change? 🤔

The ratio time limit property doesn't exist, it's always blank when trying to display it. I simply replaced it with the correct one.

@WDaan WDaan merged commit 6edde21 into master Mar 26, 2024
1 check passed
@WDaan WDaan deleted the perf/ratio_time_limit branch March 26, 2024 02:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants