Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New emit like internal-model-changed but with the same formatting as update:model-value #808

Closed
skstuder opened this issue Apr 3, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@skstuder
Copy link

skstuder commented Apr 3, 2024

Is your feature request related to a problem? Please describe.
So you guys have a handful of formats, and we have to convert them for our purposes. For example, week range format is [[Date,Date],[Date,Date]]. So we have a utility file that handles all these conversions. But we also do validations on pending updates, before the user has made a picker selection.

The problem, is the emitted data from internal-model-changed does not match the formatting of update:model-value, it seems to only emit dates that were clicked.

Describe the solution you'd like
A clear and concise description of what you want to happen.

In order to remain backwards compatible, could you make a new emit that fires at the same time as internal-model-changed, but with the formatting of update:model-value?

Describe alternatives you've considered
I won't be able to get this solution in time, and have to write a bunch of utility functions specific to translate internal-modal-changed based on props that I am using.

comparison of the two emits for a week-picker with range
Screenshot 2024-04-03 at 8 20 24 AM
Screenshot 2024-04-03 at 8 20 32 AM

@skstuder skstuder added awaiting triage The issue is not reviewed by the maintainers enhancement New feature or request labels Apr 3, 2024
@Jasenkoo Jasenkoo removed the awaiting triage The issue is not reviewed by the maintainers label Apr 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants