Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

external settings file? #561

Closed
dcsan opened this issue Nov 27, 2014 · 7 comments
Closed

external settings file? #561

dcsan opened this issue Nov 27, 2014 · 7 comments

Comments

@dcsan
Copy link

dcsan commented Nov 27, 2014

rather than configuring via the Admin login, I'd suggest using a meteor settings.json file
usually we have this per env, ie testing.json / production.json / development.json

if need be these keys can be .gitignore'd but for deployment it feels not quite reproducible to type these into a login box each time.

http://docs.meteor.com/#/full/meteor_settings

@SachaG
Copy link
Contributor

SachaG commented Nov 27, 2014

I feel like this wouldn't be very user-friendly… The goal for Telescope is to be plug-and-play without requiring any work on the user's part (or at least, as little as possible).

That being said, we could

A) use settings.json if it exists.

and/or

B) have a way to export and import settings.

@dcsan
Copy link
Author

dcsan commented Nov 27, 2014

yes you're probably right. hitting a dialog box that asks you to configure the UI is probably easier to get going with than having to edit a settings file...

but after typing this in the third or fourth time it's certainly something I'd want to automate. so look for settings first and if it's not there then show the dialog would keep everyone happy - although it would make the docs more complicated (two ways to do the same thing)

@SachaG
Copy link
Contributor

SachaG commented Nov 27, 2014

I think it could be transparent. If settings are configured through the
panel use that, if not use settings.json, if not use the default. That
sounds good to me?

On Thu, Nov 27, 2014 at 3:31 PM, dc notifications@github.com wrote:

yes you're probably right. hitting a dialog box that asks you to configure
the UI is probably easier to get going with than having to edit a settings
file...

but after typing this in the third or fourth time it's certainly something
I'd want to automate. so look for settings first and if it's not there then
show the dialog would keep everyone happy - although it would make the docs
more complicated (two ways to do the same thing)


Reply to this email directly or view it on GitHub
https://github.com/TelescopeJS/Telescope/issues/561#issuecomment-64751102
.

@SachaG SachaG closed this as completed in 1bd798f Dec 4, 2014
@SachaG
Copy link
Contributor

SachaG commented Dec 4, 2014

Done. The only other improvement I can see would be showing the value extracted from Meteor.settings in the actual settings form. But that would require messing with the quickform template, and is probably not necessary for now since this is kind of an advanced feature anyway.

@corneadoug
Copy link

I feel like I'm digging some old issues but better ask my question here.
I was looking into Telescope, and I wanted to use settings.json to be able to make a clean deployment.
The documentation wasn't giving much details. So I made a settings.json file and used it with meteor run --settings settings.json However I Can't see any of those settings being applied not showed in the admin settings section.

@SachaG
Copy link
Contributor

SachaG commented Jul 1, 2015

The settings won't show up in the admin section, but they should still be in effect. You can test it by doing Settings.get("nameOfSetting") in the browser console.

@corneadoug
Copy link

Yes, it seems its just the forms that are not showing the current values. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants