Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Video uploads larger than ~100MB fail on iOS #239

Merged
merged 4 commits into from
May 6, 2021
Merged

Conversation

kasterlod
Copy link
Contributor

@kasterlod kasterlod commented Feb 23, 2021

Summary

Test Plan

Large files to upload as a multipart. Size limit depends on device type, tested well with even over 2gb files. Without these changes, it's failing around 100mb.

What's required for testing (prerequisites)?

Prepare large file (f.e. 1gb video file)
Prepare remote server for uploading.

What are the steps to reproduce (after prerequisites)?

Try to upload large file as a multipart to your remote server with success.

Compatibility

OS Implemented
iOS
Android

Checklist

  • I have tested this on a device and a simulator
  • I added the documentation in README.md
  • I updated the typed files (TS and Flow)
  • I've added Detox End-to-End Test(s)
  • I've created a snack to demonstrate the changes: LINK HERE

@reime005
Copy link
Collaborator

reime005 commented May 5, 2021

@kasterlod can you do a rebase?

@reime005 reime005 merged commit d5798e0 into Vydia:master May 6, 2021
github-actions bot pushed a commit that referenced this pull request May 6, 2021
## [6.2.4](v6.2.3...v6.2.4) (2021-05-06)

### Bug Fixes

* video uploads larger than ~100MB fail on iOS ([#239](#239)) ([d5798e0](d5798e0)), closes [#172](#172) [#149](#149) [#53](#53) [#93](#93)
@github-actions
Copy link

github-actions bot commented May 6, 2021

🎉 This PR is included in version 6.2.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants