Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Suggestion] Hide some more useless (main?) lobby messages #50

Closed
MicrocontrollersDev opened this issue Jan 5, 2023 · 5 comments
Closed

Comments

@MicrocontrollersDev
Copy link
Collaborator

image
I have no clue what this is but its stupid and there should be a feature to remove it. As I don't know what it is and don't know all the messages since I'm sure there's more than just this one I'm just making it an issue for now.

@MicrocontrollersDev MicrocontrollersDev changed the title [Suggestion] [Suggestion] Hide some more useless (main?) lobby messages Jan 5, 2023
@xthe-dev
Copy link
Member

xthe-dev commented Jan 8, 2023

These messages appear in chat when someone catches a Special Fish while doing Main Lobby Fishing (NPC at 23 62 -35).
There are 44 messages available for each fish. I don't know if it's worth the hassle of creating 44 unique regexes.

@Wyvest
Copy link
Member

Wyvest commented Jan 8, 2023

These messages appear in chat when someone catches a Special Fish while doing Main Lobby Fishing (NPC at 23 62 -35).
There are 44 messages available for each fish. I don't know if it's worth the hassle of creating 44 unique regexes.

Do the messages not follow the same "player caught a Something" format

@xthe-dev
Copy link
Member

xthe-dev commented Jan 8, 2023

Do the messages not follow the same "player caught a Something" format

Yes, but sometimes it's "Player caught Something".
So (?<rank>\[\S+\] )?(?<player>(?!You )\w{1,16} )caught .+ should work.

@MicrocontrollersDev
Copy link
Collaborator Author

also found:

§r§c§lLobbyFishing burnt to a crisp due to a hot potato!§r
LobbyFishing burnt to a crisp due to a hot potato!

yes this guy's name is LobbyFishing.

@MicrocontrollersDev
Copy link
Collaborator Author

i’m assuming this was finished entirely, reopen if not

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants