move some patterns to LanguageData #51
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xthe-dev
added a commit
to xthe-dev/DataStorage
that referenced
this pull request
Jan 8, 2023
|
@SirXThe thanks for the DataStorage commit, I don't think there's anything else that really needs to be moved over. There are a few messages that could but really don't need to since I doubt they'll ever change and are super small so I'm leaving them as is. This PR is ready for merge or a review or whatever. |
Looks fine rn, will wait for DataStorage PR though |
This was referenced Jan 10, 2023
|
closing in favor of #53 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Move regexes to LanguageData. Will require an accompanying DataStorage PR and I'll do that after I make sure there's nothing else I should move over and to make sure this actually works because idk how DataStorage works 馃憤
How to test
Turn on an affected feature and see if it works or not (once DataStorage pr is merged)
Release Notes