Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(filters): Allow multiple selection #1202

Merged
merged 7 commits into from
Oct 26, 2023
Merged

feat(filters): Allow multiple selection #1202

merged 7 commits into from
Oct 26, 2023

Conversation

Larsluph
Copy link
Collaborator

@Larsluph Larsluph commented Oct 24, 2023

⚠️ Breaks navbar display with the rework of dashboard store structure

Fixes #1165
Fixes Larsluph#8

@Larsluph Larsluph marked this pull request as ready for review October 24, 2023 19:50
Copy link
Collaborator

@WDaan WDaan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat! Only a bit unfortunate that you have to clear your local storage to get it to work. Which for mobile devices probably means a reinstall of the PWA 🙂

src/styles/colors.scss Show resolved Hide resolved
@Larsluph
Copy link
Collaborator Author

Yeah will check later to prevent the issue because it causes the top bar to not display so you can't go to settings using the UI, you will need to go to the settings route.

@WDaan
Copy link
Collaborator

WDaan commented Oct 25, 2023

Yeah i cleared it using the console, but that's not something you can do on a phone (and isnt a very good experience in general)

Thanks for taking a look!

@Larsluph
Copy link
Collaborator Author

@WDaan Only way I found to fix that is to change the key 😄. Also took the opportunity to put it in a proper store.

@WDaan
Copy link
Collaborator

WDaan commented Oct 25, 2023

Great! Will take a look tomorrow

@WDaan
Copy link
Collaborator

WDaan commented Oct 26, 2023

This looks amazing!! 🚀 very cool

Screenshot 2023-10-26 at 11 53 01

I think this chip should have a 'clear all filters'-option
And perhaps also a clear button per filter type? 🤔

@Larsluph
Copy link
Collaborator Author

That can be a great final touch for that feature indeed! Prepend icons and listeners are already available on chips so it can be done really quickly 🚀

TODO: callbacks
@Larsluph
Copy link
Collaborator Author

Chips even have a closable attribute that shows a remove icon, callbacks are missing for now, will add them later.

@WDaan WDaan merged commit 41318c3 into VueTorrent:master Oct 26, 2023
1 check passed
@Larsluph Larsluph deleted the perf/status-filters branch October 26, 2023 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] Adding new status filter: Uploading
2 participants