-
-
Notifications
You must be signed in to change notification settings - Fork 234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(filters): Allow multiple selection #1202
Conversation
Warning: Breaks localStorage
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Neat! Only a bit unfortunate that you have to clear your local storage to get it to work. Which for mobile devices probably means a reinstall of the PWA 🙂
Yeah will check later to prevent the issue because it causes the top bar to not display so you can't go to settings using the UI, you will need to go to the settings route. |
Yeah i cleared it using the console, but that's not something you can do on a phone (and isnt a very good experience in general) Thanks for taking a look! |
@WDaan Only way I found to fix that is to change the key 😄. Also took the opportunity to put it in a proper store. |
Great! Will take a look tomorrow |
That can be a great final touch for that feature indeed! Prepend icons and listeners are already available on chips so it can be done really quickly 🚀 |
TODO: callbacks
Chips even have a closable attribute that shows a remove icon, callbacks are missing for now, will add them later. |
Fixes #1165
Fixes Larsluph#8