feat: render "active time" in torrent info tab #537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome! Seems great ;) Maybe this can also be added as a column in the dashboard card. |
WDaan
approved these changes
Nov 11, 2022
This was referenced Nov 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Render "active time" in torrent info tab [feat]
This PR adds an extra row to the "info" torrent details tab to render "time active".
I used
dayjsfor formatting durations, which isn't ideal, as there's no way to skip zero values, but it works and is a good starting point (thought it's preferrable over installing yet another library for duration formatting or making my own utility).I used the original QBit Web UI as a reference for the "time active" column and made it contain "seeding time" as well if it's greater than 0.
PR Checklist