Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: moving to vite + typescript #352

Merged
merged 27 commits into from
Nov 15, 2022
Merged

feat!: moving to vite + typescript #352

merged 27 commits into from
Nov 15, 2022

Conversation

WDaan
Copy link
Collaborator

@WDaan WDaan commented Dec 25, 2021

Vite

Move to Vite for faster build times and to remove lot of unneeded and deprecated packages.

This PR is actually quite important because right now the project is a little stuck.

node-sass/sass/sass-loader is icompatible with nodejs 16+
vue-cli-service with webpack is slow

I want to move to Vite, because it's a lot faster, but there are still some issues:

  • Proxying post requests is not working => solved
  • Make sure PWA config still works => BREAKING, users need to re-install the PWA
  • Package version fix in production build
  • vue-i18n dynamic language import

I also cant move the project to Vue3, because it relies heavily on Vuetify which does not support Vue3 yet.

PR Checklist

  • I've started from master
  • I've only committed changes related to this PR
  • All Unit tests pass
  • I've removed all commented code
  • I've removed all unneeded console.log statements

@WDaan
Copy link
Collaborator Author

WDaan commented Oct 13, 2022

Vite proxying now works again, had to disable CSRF protection during development.
Can now continue working on this branch:

  • see if PWA config works
  • move to vue3? (or maybe wait for vuetify v3 to be stable)

@WDaan
Copy link
Collaborator Author

WDaan commented Oct 22, 2022

Cant' get package version to work
PWA is still broken :(

@WDaan WDaan added the help wanted Extra attention is needed label Oct 22, 2022
@WDaan
Copy link
Collaborator Author

WDaan commented Nov 14, 2022

Fixed PWA + package version !

@WDaan WDaan changed the title perf: moving to vite [wip] perf: moving to vite + typescript Nov 15, 2022
@WDaan WDaan changed the title perf: moving to vite + typescript feat!: moving to vite + typescript Nov 15, 2022
@WDaan WDaan marked this pull request as ready for review November 15, 2022 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant