Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add links to versions #78

Merged
merged 2 commits into from
Dec 12, 2020
Merged

feat: add links to versions #78

merged 2 commits into from
Dec 12, 2020

Conversation

jef
Copy link
Contributor

@jef jef commented Dec 10, 2020

Improvements

  • Add links to VueTorrent and qBittorrent releases

Not sure if I did this right (feel free to fix). Let me know what you think.

Thanks!

@WDaan
Copy link
Collaborator

WDaan commented Dec 12, 2020

You did great!
My vue transpiler complained about the string interpolation, so I changed it a little bit.
Also the link to qbittorrent releases doenst have 'v' in them, so I had to remove it from te version

@WDaan WDaan changed the base branch from master to 0.4.7 December 12, 2020 09:10
@WDaan WDaan merged commit f7049c3 into VueTorrent:0.4.7 Dec 12, 2020
@WDaan WDaan mentioned this pull request Dec 12, 2020
Merged
@jef
Copy link
Contributor Author

jef commented Dec 12, 2020

Also the link to qbittorrent releases doenst have 'v' in them, so I had to remove it from te version

Interesting enough, on my VueTorrent, it showed without the v, so I figured it was giving without the v!

Thanks for helping me out with compiling stuff!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jef @WDaan