Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request: Twitch go-live #237

Closed
TobiTenno opened this issue Oct 25, 2018 · 6 comments · Fixed by #286
Closed

Request: Twitch go-live #237

TobiTenno opened this issue Oct 25, 2018 · 6 comments · Fixed by #286
Labels

Comments

@TobiTenno
Copy link
Member

TobiTenno commented Oct 25, 2018

Summary (short): Twitch go-live posts


Description: Would be awesome to get twitch go-live posts.


If issue, Reproduction:


Mockups, screenshots, evidence:

@TobiTenno
Copy link
Member Author

this has been on hold for a bit. someone plans to work on it, but he's been busy.

@TobiTenno TobiTenno added the Status: On Hold Accepted, but delayed by something else label Sep 4, 2019
@esunder
Copy link
Contributor

esunder commented Sep 22, 2019

@TobiTenno can I pick this up?

@TobiTenno
Copy link
Member Author

go for it

@esunder
Copy link
Contributor

esunder commented Sep 23, 2019

Couple questions:

  1. Are you expecting it to just post in the general channel when DE goes live in their twitch stream?
  2. How is Genesis deployed "in production"? If it can listen on a port, I can use Twitch's webhook system. Otherwise I'll just have to poll and look for "live" status.

@TobiTenno
Copy link
Member Author

TobiTenno commented Sep 23, 2019

As for presentation (1), i'd think integrating with the existing (soon to be reworked) notification system would be the best option.

I'm working on moving the whole notification system over to sockets from the notification "client" to a socket on warframe-status, just been having issues getting that working properly.

Re prod deployment (2): I'd mostly prefer the "list" of currently active with time active on an endpoint on the status api and have the API server use twitch's webhook system to both make the list available and update that, as well as hand off the notification of those so someone developing something against our API wouldn't need to also write their own listener for twitch, if that makes sense.... so kind of hybrid? polling every few minutes (let's say 5) after receiving an "active" event and polling on the full list on server startup to see if they're online.

We do something similar for twitter (just polling, not leveraging their webhooks if they even have a system for it)

@wfcd-bot-boi
Copy link
Contributor

🎉 This issue has been resolved in version 1.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants