Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collapse Invasions if more than 5, and add button to expand the rest #59

Closed
1 of 2 tasks
TobiTenno opened this issue Nov 21, 2017 · 7 comments
Closed
1 of 2 tasks
Labels
good first issue Good for newcomers help wanted Extra attention is needed released Scope: Core Addresses something core to warframe hub Type: Enhancement Improves existing feature

Comments

@TobiTenno
Copy link
Member

Warframe Hub Issue



Summary (short): Hide invasions if there are more than 5


Description: This would save space and make sure users know there's more below.
I don't know how we'd implement it, precisely, but it'd be fantastic


Mockups, screenshots, evidence:


(Check one)

  • Issue
  • Suggestion
@Tithen-Firion
Copy link
Contributor

Just dropping bits of code that will help:
$('#invasionList > li.list-group-item-borderless:nth-child(n+6)').slideToggle() (or slideUp and slideDown)

Of course you also need to show invasions that are hidden after one of 5 visible ones ends:
$('#invasionList > li.list-group-item-borderless:nth-child(-n+5)').show()

@TobiTenno
Copy link
Member Author

if you wanna make a quick pull just to see how it looks, i'll happily review it really quick and see how it looks. i'll add you to the org so it'll make a build for you

@TobiTenno TobiTenno removed the backlog label Jan 25, 2018
@TobiTenno TobiTenno added this to the Warframe Hub 2.0 milestone Jan 14, 2019
@EricSihaoLin
Copy link
Member

I'm rethinking this, would a scrollable panel work?
The only problem is, how would the user know it is a scrollable area?

@dsinn
Copy link
Contributor

dsinn commented Jan 16, 2019

If the scrollbar is visible, it may be okay. Having a faded effect when you're not at the end of the content could also help, although I don't have the CSS savvy for the implementation details.

@TobiTenno TobiTenno added good first issue Good for newcomers help wanted Extra attention is needed Scope: Core Addresses something core to warframe hub Type: Enhancement Improves existing feature labels May 7, 2019
@TobiTenno TobiTenno removed this from the Warframe Hub 2.0 milestone May 7, 2019
@107g
Copy link
Contributor

107g commented Jun 9, 2019

Hello there,

I just digged up that issue. I'm trying to implement that feature by reusing the 'Collapsible' component used for Bounties.

@TobiTenno
Copy link
Member Author

I look forward to seeing what you do with it

@wfcd-bot-boi
Copy link
Collaborator

🎉 This issue has been resolved in version 1.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed released Scope: Core Addresses something core to warframe hub Type: Enhancement Improves existing feature
Projects
None yet
Development

No branches or pull requests

6 participants