Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use model only for sound filters #889

Merged
merged 1 commit into from Oct 19, 2022
Merged

fix: use model only for sound filters #889

merged 1 commit into from Oct 19, 2022

Conversation

TobiTenno
Copy link
Member

Summary:
just use model instead of extra method

Fixes issue (include link):
closes #882

Mockups, screenshots, evidence:

@TobiTenno TobiTenno requested a review from a team as a code owner October 19, 2022 17:58
@vercel
Copy link

vercel bot commented Oct 19, 2022 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
warframe-hub ✅ Ready (Inspect) Visit Preview Oct 19, 2022 at 5:59PM (UTC)

@TobiTenno TobiTenno enabled auto-merge (squash) October 19, 2022 17:59
@TobiTenno TobiTenno merged commit 89555e4 into dev Oct 19, 2022
@TobiTenno TobiTenno deleted the bugs/882 branch October 19, 2022 19:07
wfcd-bot-boi pushed a commit that referenced this pull request Oct 19, 2022
@semantic-release-bot
chore(release): 2.2.3 [skip ci]
9a7721a 
## [2.2.3](v2.2.2...v2.2.3) (2022-10-19)

### Bug Fixes

* use model only for sound filters ([#889](#889)) ([89555e4](89555e4)), closes [#882](#882)
@wfcd-bot-boi
Copy link
Collaborator

🎉 This PR is included in version 2.2.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EricSihaoLin EricSihaoLin EricSihaoLin approved these changes

@Bitti09 Bitti09 Awaiting requested review from Bitti09 Bitti09 is a code owner automatically assigned from WFCD/warframe-hub

@aj-rom aj-rom Awaiting requested review from aj-rom

@atomicptr atomicptr Awaiting requested review from atomicptr

@AyAyEm AyAyEm Awaiting requested review from AyAyEm

@dsinn dsinn Awaiting requested review from dsinn

@Erlite Erlite Awaiting requested review from Erlite

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🐛 sound filters
3 participants
@TobiTenno @wfcd-bot-boi @EricSihaoLin