Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Hero Image and Cover Image required for Exhibit and Collection #154

Open
Tracked by #158
foglabs opened this issue Feb 7, 2024 · 1 comment
Open
Tracked by #158
Assignees
Labels
bug 🐛 Something isn't working enhancement ➕ New feature or request question ❔ Further information is requested

Comments

@foglabs
Copy link
Contributor

foglabs commented Feb 7, 2024

Because

Because hero image and cover image are used across the site on various pages, exhibits and collections should require both image fields to be filled.

Done when

  • [ ]
@mrharpo mrharpo added enhancement ➕ New feature or request bug 🐛 Something isn't working labels Feb 7, 2024
@mrharpo mrharpo self-assigned this Feb 7, 2024
@mrharpo
Copy link
Contributor

mrharpo commented Feb 7, 2024

@foglabs I like the idea, but I'm not sure if it should be a hard requirement for the record. E.g:

if a content editor wants to create a record stub (as a draft) they would have to add both images (or 2 placeholders) before they could save it, even as a draft.

Hooks

Wagtail has a before-publish-page hook that we can use to make sure everything is there before publishing.

With that in mind, can the frontend render a placeholder image (OV logo?) to display on demo for such cases?

@mrharpo mrharpo linked a pull request Feb 8, 2024 that will close this issue
@mrharpo mrharpo removed a link to a pull request Feb 8, 2024
@mrharpo mrharpo mentioned this issue Feb 8, 2024
@mrharpo mrharpo added the question ❔ Further information is requested label Feb 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something isn't working enhancement ➕ New feature or request question ❔ Further information is requested
Projects
Status: 📋 Backlog
Development

No branches or pull requests

2 participants