-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename allowOnBattery to chargingOnly? #35
Comments
|
Deliberately so. It also closer matches what I've seen in beyondpod (Android podcast app), the option is "Download if charging only". That's a single data point though. |
Oops, my bad. |
ACRequired? Would that be acRequired? |
Yes, chargingOnly was avoided as it doesn't really make sense for systems without batteries. |
|
I'm shying away from anything that involves "discharge" because ew. "wired" is ambiguous with network.
|
acOnly works for me. |
"ac" stands for alternative current, right? That doesn't seem very timeless either. (I don't really care, but the reasoning doesn't seem consistent.) |
|
|
|
If you want to avoid using the term BAttery since some devices don't have them, I'd suggest using "power" instead. PowerSaving or ConservePower maybe? |
We want a term that indicates synchronization should not be performed when the devices has a finite power source and is also reasonably clear. |
Such a difficult thing to name. Then there is the question of laptops. If it's set to |
That is why |
Periodic should default to charging, one-shot shouldn't. Not sure how we can make that false for both without changing the name for each, or simply not exposing the option to one-shot. |
Do we absolutely need a boolean option? Could we have a 3 states option:
Hmm,
|
Different approach, what do we expect the UX for this to be? Are we going to communicate this to the user somehow without things getting overly complex? |
I imagine that we might to want to show these nuances in the context of a battery usage audit page. We don't have a concrete plan yet so this is just my own attempt at one.
Approximately:
|
That makes sense. If we have that, I think exposing that level of granularity to the API seems about right as well. Which means we don't really have to worry about ac or batteries. |
Agreed. More reason to split the APIs. @KenjiBaheux I like this. The user should be able to say "This origin should not be allowed to sync while battery is draining", "This origin should not be able to sync while on cellular". I'd like to avoid
…I can't think of a good one for "auto" means the UA can impose extra restrictions based on user settings, battery saving modes, roaming etc. The developer can only self-impose restrictions. |
The draft periodic idl now has avoid-draining. |
Or something else that gives us a falsey default.
I'm guessing something like
chargingOnly
was avoided because of devices that don't have a battery? I guess something likepowerConnectedOnly
avoids that.The text was updated successfully, but these errors were encountered: