New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
If 'InputDevice' isn't about the device itself, but about its capabilities, rename the interface? #19
Comments
The least 'capability-like' API suggested in the brainstorming doc is 'isCurrentlyOnScreen' (for virtual keyboards). That's more like 'state' than 'capabilities', but seems pretty close. So I'm OK with "InputDeviceCapabilities" and "sourceCapabilities" if that's the consensus. @patrickhlauke @jacobrossi @garykac @tdresser @summerww any opinion? |
Also +@mbrubeck since he contributed to the original design discussion here on the TECG call |
DeviceCapabilities sounds good to me. If we do that, I think that it makes sense to remove DeviceClass entirely. If something like the class is still desirable, then I'd prefer something On Thu, Aug 6, 2015 at 4:08 AM, Rick Byers notifications@github.com wrote:
|
+1 to making the name less ambiguous and more about capabilities. if we do want something state-like (as in the keyboard example), maybe calling it characteristics, rather than capabilities, which would perhaps cover the second case as well? |
This approach also implies that testing equality isn't meaningful. Intuitively, I'd expect that if the LGTM! |
Thanks everyone! @garykac I don't think we can use So concrete proposal is:
Let's keep the discussion open for another day or two, then @Summerlw says she will do the renames (spec, polyfill, tests, and blink implementation). |
Done |
If 'InputDevice' isn't about the device itself, but about its capabilities, should the interface be renamed?
Like InputDeviceCapabilities and then UIEvent could have something like
InputDeviceCapabilities? sourceCapabilities = null;
This way one doesn't immediately expect the interface to have something like
readonly attribute DOMString type; // mouse, pen ...
The text was updated successfully, but these errors were encountered: