Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IntersectionObserverInit.threshold vs. IntersectionObserver.thresholds #215

Open
a2sheppy opened this issue May 26, 2017 · 2 comments
Open

Comments

@a2sheppy
Copy link

This naming is going to (and already has) lead to bugs because of that "s". These two things are essentially the same data. I suggest that these names should be the same, for consistency and to help reduce bugs due to accidentally using or leaving out the "s" and then spending hours trying to figure out why your code isn't working. I wasted last Friday on this exact issue.

@ziyunfei
Copy link

I agree, but it's too late.

@ojanvafai
Copy link
Collaborator

Ugh. @szager-chromium maybe we should make it so IntersectionObserverInit can take either "threshold" or "thresholds"? That downside to that is that the generation of browsers that ship the current API won't work if people use thresholds.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants